Skip to content

feat(mainnet-nns): generate dictator neuron secret key at runtime#9715

Merged
pierugo-dfinity merged 6 commits intomasterfrom
pierugo/mainnet-proposals/generate-secret-key-at-runtime
Apr 8, 2026
Merged

feat(mainnet-nns): generate dictator neuron secret key at runtime#9715
pierugo-dfinity merged 6 commits intomasterfrom
pierugo/mainnet-proposals/generate-secret-key-at-runtime

Conversation

@pierugo-dfinity
Copy link
Copy Markdown
Contributor

@pierugo-dfinity pierugo-dfinity commented Apr 2, 2026

This PR generates the dictator neuron's private key in testnets using mainnet state at runtime instead of using a hard-coded private key.

@github-actions github-actions bot added the feat label Apr 2, 2026
@pierugo-dfinity pierugo-dfinity marked this pull request as ready for review April 8, 2026 09:06
@pierugo-dfinity pierugo-dfinity requested a review from a team as a code owner April 8, 2026 09:06
Comment thread rs/tests/testnets/mainnet_nns/src/proposals.rs Outdated
Comment thread rs/tests/testnets/mainnet_nns/src/lib.rs Outdated
Comment thread rs/tests/testnets/mainnet_nns/src/proposals.rs
Copy link
Copy Markdown
Contributor

@kpop-dfinity kpop-dfinity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with 2 nits

Comment thread rs/tests/testnets/mainnet_nns/src/lib.rs Outdated
Comment thread rs/tests/testnets/mainnet_nns/src/proposals.rs Outdated
@pierugo-dfinity pierugo-dfinity added this pull request to the merge queue Apr 8, 2026
Merged via the queue into master with commit 434b1e1 Apr 8, 2026
63 of 64 checks passed
@pierugo-dfinity pierugo-dfinity deleted the pierugo/mainnet-proposals/generate-secret-key-at-runtime branch April 8, 2026 14:38
daniel-wong-dfinity-org pushed a commit that referenced this pull request Apr 15, 2026
)

This PR generates the dictator neuron's private key in testnets using
mainnet state at runtime instead of using a hard-coded private key.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants